Attention is currently required from: Felix Singer.
Maximilian Brune has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/83226?usp=email )
Change subject: Makefile.mk: Use one line per *_common flag
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
And now I saw a merge conflict because of this. Please always keep in […]
I don't like this rule at all. None one will comply to this and even if they would it would only cause people to not do style changes/enhancements in the first place. You shouldn't care too much about other patches. Just rebase your patches (that is not hard) in case of merge conflicts and be done with it. No need to make it unnecessary complicated
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83226?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I33c500e6eb74daf1e66c2b5e07b50f81c0f4587d
Gerrit-Change-Number: 83226
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Comment-Date: Fri, 19 Jul 2024 12:35:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
