Attention is currently required from: Wonkyu Kim, Paul Menzel, Angel Pons. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63615 )
Change subject: intel/common/../systemagent: Enable MCHBAR in bootblock ......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63615/comment/25af1ba3_8fbba25b PS4, Line 10: As there is no harm to enable : MCHBAR from bootblock even in existing plaforms
Enabling MCHBAR takes a PCI config register write or two, so size isn't a concern. The main reason is that the GPMR driver needs to access MCHBAR registers in bootblock code.
+1 to Angel's question. do we need to use GPMR access even in bootblock. Today with ADL and previous generation I don't see such usage.
https://review.coreboot.org/c/coreboot/+/63615/comment/7d4ea582_2b015909 PS4, Line 13:
Yes, I'd consider removing the code enabling MCHBAR in romstage.
Yes, if we need this is call in bootblock then better to remove from romstage