Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45344 )
Change subject: soc/intel/common/block/cpu: Fix boot failure ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45344/1/src/soc/intel/common/block/... File src/soc/intel/common/block/cpu/cpulib.c:
https://review.coreboot.org/c/coreboot/+/45344/1/src/soc/intel/common/block/... PS1, Line 349: if (!CONFIG(SOC_INTEL_COMMON_BLOCK_SGX)) : return 0;
Looking at the Kconfig PRMRR is always disabled when SGX disabled, so this condition is correct.
yes, *now* it does that, after guarding that with if's, but that was probably wrong already ;) we need to find a definitive answer if prmrr makes any sense without sgx
https://review.coreboot.org/c/coreboot/+/45344/1/src/soc/intel/common/block/... PS1, Line 352: if (CONFIG(SOC_INTEL_COMMON_BLOCK_SGX_PRMRR_DISABLED)) { : printk(BIOS_DEBUG, "PRMRR disabled by config.\n"); : return 0; : }
What's this for, then?
you CAN disable prmrr