Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34355 )
Change subject: nb/via/vx900: Ensure framebuffer size is within limits
......................................................................
Patch Set 6: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/34355/6/src/northbridge/via/vx900/m...
File src/northbridge/via/vx900/memmap.c:
https://review.coreboot.org/c/coreboot/+/34355/6/src/northbridge/via/vx900/m...
PS6, Line 85: u8 fb_pow = 0;
: do {
: fb_pow++;
: } while (size_mb >> fb_pow);
: fb_pow--;
:
: size_mb = (1U << fb_pow);
Nit, with the die() in place, it should be the same as
size_mb = 1u << log2(size_mb);
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34355
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3962e5cdc094c8da22d8dbadf16637e02fa98689
Gerrit-Change-Number: 34355
Gerrit-PatchSet: 6
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 18 Jul 2019 09:45:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment