Christoph Pomaska has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34905 )
Change subject: mb/supermicro/x10slm-f: Fix IPMI KCS ......................................................................
Patch Set 13:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34905/8/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x10slm-f/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/34905/8/src/mainboard/supermicro/x1... PS8, Line 5: ## Copyright (C) 2019 Hosting.de GmbH c.pomaska@hosting.de
Well, it wouldn't be any problem if there was a Copyright on the original work. […]
Removed my copyright string in the latest patch set - problem solved I guess.
https://review.coreboot.org/c/coreboot/+/34905/9/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x10slm-f/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/34905/9/src/mainboard/supermicro/x1... PS9, Line 96: io 0x60 = 0xa00
missing lpc_gen_dec
Done
https://review.coreboot.org/c/coreboot/+/34905/9/src/mainboard/supermicro/x1... PS9, Line 113: io 0x60 = 0x3e8
missing lpc_gen_dec
Done
https://review.coreboot.org/c/coreboot/+/34905/9/src/mainboard/supermicro/x1... PS9, Line 117: io 0x60 = 0x2e8
missing lpc_gen_dec
Done