Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30987 )
Change subject: mb/asus: Add Asus A88XM-E FM2+ with documentation ......................................................................
Patch Set 67:
(5 comments)
https://review.coreboot.org/c/coreboot/+/30987/66/src/mainboard/asus/a88xm-e... File src/mainboard/asus/a88xm-e/acpi/cpstate.asl:
https://review.coreboot.org/c/coreboot/+/30987/66/src/mainboard/asus/a88xm-e... PS66, Line 9:
Starting here, you can drop a tab on the rest of the file
Done
https://review.coreboot.org/c/coreboot/+/30987/66/src/mainboard/asus/a88xm-e... File src/mainboard/asus/a88xm-e/acpi/gpe.asl:
https://review.coreboot.org/c/coreboot/+/30987/66/src/mainboard/asus/a88xm-e... PS66, Line 19: Notify (_TZ.TZ00, 0x80)
This shouldn't be commented-out
Done
https://review.coreboot.org/c/coreboot/+/30987/62/src/mainboard/asus/a88xm-e... File src/mainboard/asus/a88xm-e/buildOpts.c:
https://review.coreboot.org/c/coreboot/+/30987/62/src/mainboard/asus/a88xm-e... PS62, Line 50: //#define BLDOPT_REMOVE_UDIMMS_SUPPORT TRUE
You want to debug by removing UDIMM support?
Done
https://review.coreboot.org/c/coreboot/+/30987/66/src/mainboard/asus/a88xm-e... File src/mainboard/asus/a88xm-e/buildOpts.c:
https://review.coreboot.org/c/coreboot/+/30987/66/src/mainboard/asus/a88xm-e... PS66, Line 74: /* This
Multi-line comments in coreboot should start like this: […]
Done
https://review.coreboot.org/c/coreboot/+/30987/62/src/mainboard/asus/a88xm-e... File src/mainboard/asus/a88xm-e/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/30987/62/src/mainboard/asus/a88xm-e... PS62, Line 64: io 0x60 = 0x3f0 : irq 0x70 = 6 : drq 0x74 = 2
No, don't remove the whole device, only the things inside it: […]
Done