Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34972 )
Change subject: lib/bootblock: Add simplified entry with basetime
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34972/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34972/3//COMMIT_MSG@11
PS3, Line 11: with calls to timestamp_add() gets removed from bootblock.
Here's the assembly. […]
Ohh... interesting. Looks like the compiler is clever enough to see that both callers (bootblock_main_with_basetime() and main()) always pass NULL and 0 there (and you're not compiling _start() for your build). So I guess we can keep it like this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34972
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id230075c0e76fe377b6ea8c8ddf8318e07d29b91
Gerrit-Change-Number: 34972
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Vanny E
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 21 Aug 2019 22:40:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment