Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36168 )
Change subject: soc/intel/common: Make native and FSP-T CAR init mutually exclusive ......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/c/coreboot/+/36168/5/src/soc/intel/common/block/... File src/soc/intel/common/block/cpu/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/36168/5/src/soc/intel/common/block/... PS5, Line 1: n
why the negation? it makes it much harder too read, imho
moved
https://review.coreboot.org/c/coreboot/+/36168/5/src/soc/intel/common/block/... PS5, Line 10:
double empty lines
Done
https://review.coreboot.org/c/coreboot/+/36168/6/src/soc/intel/common/block/... File src/soc/intel/common/block/cpu/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/36168/6/src/soc/intel/common/block/... PS6, Line 1: ifeq ($(CONFIG_FSP_CAR),n)
It's not 'n' if not selected.
Ack, but it's y if selected ;) you could check for an empty string, or what I would prefer: check for y and switch the if/else blocks.