Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43645 )
Change subject: mb/system76/lemp9: gpio: disable internal SATAXPCIE pull-ups ......................................................................
mb/system76/lemp9: gpio: disable internal SATAXPCIE pull-ups
Disable internal pull-ups for SATAXPCIE pads since there are external ones at the M.2 slot's PEDET pins.
Test: both, SATA and NVME devices work fine on both slots
Signed-off-by: Michael Niewöhner foss@mniewoehner.de Change-Id: I6be716620695ac38c44a17abe1c4de97b099b8d7 Reviewed-on: https://review.coreboot.org/c/coreboot/+/43645 Reviewed-by: Felix Singer felixsinger@posteo.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/system76/lemp9/gpio.h 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved
diff --git a/src/mainboard/system76/lemp9/gpio.h b/src/mainboard/system76/lemp9/gpio.h index b2d08cc..b631ade 100644 --- a/src/mainboard/system76/lemp9/gpio.h +++ b/src/mainboard/system76/lemp9/gpio.h @@ -321,9 +321,9 @@ // NC PAD_NC(GPP_E0, UP_20K), // SATAGP1 - PAD_CFG_NF(GPP_E1, UP_20K, DEEP, NF1), + PAD_CFG_NF(GPP_E1, NONE, DEEP, NF1), // SATAGP2 - PAD_CFG_NF(GPP_E2, UP_20K, DEEP, NF1), + PAD_CFG_NF(GPP_E2, NONE, DEEP, NF1),
// CPU Misc // NC