[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso: Add generic SMU service request

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41625 )

Change subject: soc/amd/picasso: Add generic SMU service request
......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/c/coreboot/+/41625/1/src/soc/amd/picasso/smu.c 
File src/soc/amd/picasso/smu.c:

https://review.coreboot.org/c/coreboot/+/41625/1/src/soc/amd/picasso/smu.c@4... 
PS1, Line 47:
> i'd say that it's done, but needs to be tested, so i leave this one open until it's tested again

Done

https://review.coreboot.org/c/coreboot/+/41625/4/src/soc/amd/picasso/smu.c 
File src/soc/amd/picasso/smu.c:

https://review.coreboot.org/c/coreboot/+/41625/4/src/soc/amd/picasso/smu.c@3... 
PS4, Line 38: usecs
> This is usecs, the comment says msecs. […]

that's from the first revision of the patch where this function was only used after the smu_write32(REG_ADDR_MESG_ID, id) call. I'll fix this in a follow-up. So the 1us is the one check if the SMU is ready to accept a new command. In the case of the SMC_MSG_S3ENTRY command, the x86 cores are stopped shortly after the smu_write32(REG_ADDR_MESG_ID, id) call, so the second time the message won't get printed