Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36664 )
Change subject: x86/tsc: Only call tsc_freq_mhz once to init clock
......................................................................
Patch Set 1:
Patch Set 1:
I need to see the arguments why this was abandoned. Or in other words, where was the fix? Are we hitting some CPU errata or undisclosed silicon bug?
The failure was occurring after FSP-S requested a reset. Inside of FSP it was applying power management configuration. Prior to the mainboard policy being deployed the reset would happen. On that subsequent boot we were missing h1 interrupts because of the of power management policy. I cannot claim that I understand why this CL would help in such scenarios, though.
https://review.coreboot.org/c/coreboot/+/37319 was the solution people came up with for ensuring the mainboard power management policy was provisioned.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36664
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8e9edafa3007568e8d27e3c19c9fd6fa7637786c
Gerrit-Change-Number: 36664
Gerrit-PatchSet: 1
Gerrit-Owner: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Thu, 05 Dec 2019 15:48:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment