[coreboot-gerrit] Change in ...coreboot[master]: string.h: allow to compile strdup in romstage

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30844 )

Change subject: string.h: allow to compile strdup in romstage
......................................................................

Patch Set 4:
> Patch Set 4:
>
> Again, I wanna plug using the dead_code() macro for this. It would lead to a message like:
>
> src/include/assert.h:57:2: error: call to 'dead_code_assertion_failed_57' declared with attribute error: "strdup() must not be used in romstage!" in src/include/string.h:24
>
> when you try to build it the wrong way, and it would also make it clear to anyone reading the strdup() code that this is intentional.

Definitely agree.