Patch Set 4:

Again, I wanna plug using the dead_code() macro for this. It would lead to a message like:

src/include/assert.h:57:2: error: call to 'dead_code_assertion_failed_57' declared with attribute error: "strdup() must not be used in romstage!" in src/include/string.h:24

when you try to build it the wrong way, and it would also make it clear to anyone reading the strdup() code that this is intentional.

Definitely agree.

View Change

To view, visit change 30844. To unsubscribe, or for help writing mail filters, visit settings.