Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34149 )
Change subject: intel/e7505,i82801dx: Fix SMM_ASEG lock
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34149/2/src/northbridge/intel/e7505...
File src/northbridge/intel/e7505/memmap.c:
https://review.coreboot.org/c/coreboot/+/34149/2/src/northbridge/intel/e7505...
PS2, Line 38: void northbridge_write_smram(u8 smram);
Do we need a separate declaration here?
I did not want to pull in SMM_TSEG headers just yet. I got the hardware, will convert to TSEG and this will look prettier.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34149
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I21d991c8c2f5c2dde1f148fd80963e39d9836d3c
Gerrit-Change-Number: 34149
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 10 Jul 2019 11:17:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment