Attention is currently required from: Nico Huber, Kyösti Mälkki, Piotr Król.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52934 )
Change subject: nb/amd/agesa/family14: Use generic allocation functions for northbridge
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52934/comment/0796b7e7_8418f087
PS2, Line 9: Remove obsolete resource assigning functions.
Elaborated a bit in the commit message attempting to explain it.
Done
File src/northbridge/amd/agesa/family14/northbridge.c:
https://review.coreboot.org/c/coreboot/+/52934/comment/5fd69c73_597bdf32
PS2, Line 448: set_resource(dev, res, nodeid);
Right, the respective code in nb_read_resources does not do anything meaningful too. Removed.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52934
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I74a0ed1fcbbc9e066c42c4d51d30ab1d7138134a
Gerrit-Change-Number: 52934
Gerrit-PatchSet: 4
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Comment-Date: Fri, 14 May 2021 09:39:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-MessageType: comment