Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31235 )
Change subject: soc/intel: Add mem_rank info in SMBIOS ......................................................................
Patch Set 11:
(1 comment)
Patch Set 11:
(1 comment)
Patch Set 11:
Patch Set 11:
Patch Set 11:
(1 comment)
Not quite sure why that is. The build failure is not related to this change. I just clone the coreboot.org repo and RankInDimm is indeed present in DIMM_INFO from /src/vendorcode/intel/fsp/fsp2_0/glk/FspmUpd.h
But it's not in the apollolake fspupd which is causing the failures.
My build infrastructure did build for GLK, not apollolake (APL). Which is why I did not get this error. This value will be set to 0 in the APL call. The originally missing RankInDimm bug was filed for GLK. Aaron, in case this is also needed for APL, I would suggest that you please file a partner issue for APL, so that FSP team for APL can add that field in their UDP info.
See my comment in meminit_util_apl.c. The CL cannot go in because its referencing things that don't exist.
https://review.coreboot.org/#/c/31235/11/src/soc/intel/apollolake/meminit_ut... File src/soc/intel/apollolake/meminit_util_apl.c:
https://review.coreboot.org/#/c/31235/11/src/soc/intel/apollolake/meminit_ut... PS11, Line 88: src_dimm->RankInDimm
Build bot seems to be failing because this field is not present in DIMM_INFO. […]
In order for the builds to pass this needs to be set to 0 as there aren't fields that cover this.