Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35296 )
Change subject: soc/amd/picasso: Refactor AOAC enabling ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35296/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35296/1//COMMIT_MSG@13 PS1, Line 13: Picasso's UARTs UART0 and UART1 are... and you code enforces UART0 or UART1. If your code also accepted the other UARTs, then this would be accurate. Why not simply say that UART enabling is now controlled by a config parameter?
https://review.coreboot.org/c/coreboot/+/35296/1/src/soc/amd/picasso/southbr... File src/soc/amd/picasso/southbridge.c:
https://review.coreboot.org/c/coreboot/+/35296/1/src/soc/amd/picasso/southbr... PS1, Line 52: */ Maybe add why? I had to look the code below to understand it had a control through config PICASSO_UART. Just a suggestion, I accept either way.