Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39894 )
Change subject: tests: Add build subsystem for unit testing coreboot ......................................................................
Patch Set 4: Code-Review+2
(3 comments)
Cool, I think for a first version this is good to go!
https://review.coreboot.org/c/coreboot/+/39894/3/Makefile File Makefile:
https://review.coreboot.org/c/coreboot/+/39894/3/Makefile@171 PS3, Line 171: include $(DOTCONFIG)
I was thinking about that we may want to include toolchain. […]
Hmm... okay, fair enough, I see that there are some benefits to that (e.g. also handling CONFIG_CCACHE). Not sure what the best answer is. Maybe we should translate the few Kconfig options toolchain.inc cares about into Makefile variables first. Or maybe it's right to have menuconfig affect unit tests for those build-specific options after all.
Can probably be solved at a later time, though.
https://review.coreboot.org/c/coreboot/+/39894/3/tests/Makefile.inc File tests/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/39894/3/tests/Makefile.inc@58 PS3, Line 58: $$($(1)-stage)
This won't be doable unless we do traverse through all src/directories (currently, we are not invoki […]
Ack. I would prefer no redundancy but in practice I guess we don't add new stages often enough for this to matter.
https://review.coreboot.org/c/coreboot/+/39894/4/tests/Makefile.inc File tests/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/39894/4/tests/Makefile.inc@54 PS4, Line 54: filter nit: simpler with $(findstring)