HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45451 )
Change subject: nb/intel/gm45: Introduce memmap.h
......................................................................
Patch Set 3:
(1 comment)
Would you mind not doing no-op in this code while it's being rewritten anyway ( CB:45610 )?
https://review.coreboot.org/c/coreboot/+/45451/3/src/northbridge/intel/gm45/...
File src/northbridge/intel/gm45/gm45.h:
https://review.coreboot.org/c/coreboot/+/45451/3/src/northbridge/intel/gm45/...
PS3, Line 173: #define DEFAULT_MCHBAR 0xfed14000
: #define DEFAULT_DMIBAR 0xfed18000
: #define DEFAULT_EPBAR 0xfed19000
please see https://review.coreboot.org/c/coreboot/+/45610/17
Thx
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45451
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idddb63069b7a0b7b4d6c7850473a71318748bb9b
Gerrit-Change-Number: 45451
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 14 Oct 2020 08:59:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment