Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39125 )
Change subject: mb/kontron/986lcd-m: Use `winbond_enable_serial()`
......................................................................
Patch Set 1: Code-Review+1
Patch Set 1:
Felix, any suggestions regarding the `pnp_set_irq()` integration?
What's the default value according to the SIO datasheet? If it's the same, it's probably not a big deal.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39125
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia437aa31ae92a299d0d0b35db15715997ee9bad3
Gerrit-Change-Number: 39125
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 26 Feb 2020 15:45:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment