[coreboot-gerrit] Change in coreboot[master]: soc/amd/common: Handle power resume after power failure

[Marshall Dawson (Code Review)]

Attention is currently required from: Jason Glenesk, Raul Rangel, Furquan Shaikh, Martin Roth, Karthik Ramasubramanian, Felix Held.
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51924 )

Change subject: soc/amd/common: Handle power resume after power failure
......................................................................

Patch Set 4:

(2 comments)

File src/soc/amd/common/block/pm/Kconfig:

https://review.coreboot.org/c/coreboot/+/51924/comment/ecc44c1a_13ad9619 
PS4, Line 5: select POWER_STATE_DEFAULT_ON_AFTER_FAILURE
> nit: Probably add it as: […]

Yeah, I'm not a fan of selecting the default behavior at the soc either.  If fact, I would go so far as to not add "default y" - just let the coreboot default be in play unless the mainboard sets its preference.

File src/soc/amd/common/block/pm/pmlib.c:

https://review.coreboot.org/c/coreboot/+/51924/comment/9d4bdc0f_0bf2212b 
PS4, Line 10: 0x4
> nit: Use (1 << 2)? It is the same value, but I think it is easier to understand that this is referri […]

amd/common also uses a lot of BIT(x)