Attention is currently required from: Elyes Haouas, Ivan Jager.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78239?usp=email )
Change subject: cbfs: Restore 32-bit padding in cbfs_header
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
Yeah, sorry, this should have never been changed. cbfstool is using sizeof() on that structure so the size of the `pad[1]` member was important.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78239?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4199dcc4823469c5986ac967a55b1c85cc62f780
Gerrit-Change-Number: 78239
Gerrit-PatchSet: 1
Gerrit-Owner: Ivan Jager
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Ivan Jager
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Thu, 05 Oct 2023 21:16:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment