Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42189 )
Change subject: nb/intel/gm45: Use PCI bitwise ops
......................................................................
Patch Set 7: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/42189/7/src/northbridge/intel/gm45/...
File src/northbridge/intel/gm45/early_reset.c:
https://review.coreboot.org/c/coreboot/+/42189/7/src/northbridge/intel/gm45/...
PS7, Line 44:
why the newlines?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42189
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icaca44280acdba099a5e13c5fd91d82c3e002bae
Gerrit-Change-Number: 42189
Gerrit-PatchSet: 7
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 11 Jul 2020 00:08:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment