Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41728 )
Change subject: drivers/intel/fsp2_0: Add FSP 2.2 specific support ......................................................................
Patch Set 9:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41728/9/src/drivers/intel/fsp2_0/si... File src/drivers/intel/fsp2_0/silicon_init.c:
https://review.coreboot.org/c/coreboot/+/41728/9/src/drivers/intel/fsp2_0/si... PS9, Line 46: !=
This isn't the correct way to test for success anyway. It should be if(!EFI_ERROR(status)). […]
Ack
https://review.coreboot.org/c/coreboot/+/41728/9/src/drivers/intel/fsp2_0/si... PS9, Line 59: FSP_MULTI_PHASE_SI_INIT_GET_NUMBER_OF_PHASES_API
Should we attempt to continue to boot without multiphase in this case rather than treat this as fata […]
Ack
https://review.coreboot.org/c/coreboot/+/41728/9/src/drivers/intel/fsp2_0/si... PS9, Line 66: "
prefix with "FspMultiPhaseSiInit ExecutePhase" (for consistency with other output)
Ack