Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42994 )
Change subject: mb/google/hatch: Allow USB2/3 wakeups to (un)plug events in Wyvern
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42994/1/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/wyvern/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42994/1/src/mainboard/google/hatch/...
PS1, Line 85: register "usb2_wake_enable_bitmap" = "USB_PORT_WAKE_ENABLE(1) | \
These should match noibat.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42994
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ideacac417a46b96f3e82b53bbb341ecce79ee420
Gerrit-Change-Number: 42994
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Sam McNally
sammc@google.com
Gerrit-Comment-Date: Thu, 02 Jul 2020 03:42:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment