Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36251 )
Change subject: soc/mediatek/mt8183: Force retraining memory if requested ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36251/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36251/1//COMMIT_MSG@14 PS1, Line 14: On x86 (MRC cache) this is primarily used for ensuring RO calibration
I don't actually see any other coreboot code referencing this reason. […]
That is in vboot_reference. see firmware/lib/vboot_api_kernel.c#L305.
Maybe I should clarify: it was made for MRC cache, although the real implementation was inside vboot.
https://review.coreboot.org/c/coreboot/+/36251/1/src/soc/mediatek/mt8183/mem... File src/soc/mediatek/mt8183/memory.c:
https://review.coreboot.org/c/coreboot/+/36251/1/src/soc/mediatek/mt8183/mem... PS1, Line 173: vboot_check_recovery_request() == VB2_RECOVERY_TRAIN_AND_REBOOT) {
When it says TRAIN_AND_REBOOT, should it actually reboot afterwards? What are the expected semantics […]
vboot will reboot after seeing that.