Attention is currently required from: Eran Mitrani, Kapil Porwal, Paul Menzel, Subrata Banik, Tarun.
Kun Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78295?usp=email )
Change subject: Revert "mb/google/rex/var/screebo: Enable GL9750 invert WP function"
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78295/comment/bf37c3d5_47dd6585 :
PS2, Line 11: Added
Do you mean: In schematic X a sdcard write protection pull-down … was added, so …
yes
https://review.coreboot.org/c/coreboot/+/78295/comment/369916be_6471b170 :
PS2, Line 12: hardware,so
Please add a space after the comma.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78295?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I00a8f43094d8b3674a4bbaeed24b96aab64b9b75
Gerrit-Change-Number: 78295
Gerrit-PatchSet: 3
Gerrit-Owner: Kun Liu
liukun11@huaqin.corp-partner.google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Rui Zhou
zhourui@huaqin.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Mon, 09 Oct 2023 11:17:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment