Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46293 )
Change subject: mb/google/volteer: add generic DDR4 SPDs for Lindar
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46293/1/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/lindar/memory/dram_id.generated.txt:
https://review.coreboot.org/c/coreboot/+/46293/1/src/mainboard/google/voltee...
PS1, Line 2: MT53E512M32D2NP-046 WT:E 0 (0000)
: K4U6E3S4AA-MGCR 1 (0001)
: H9HCNNNBKMMLXR-NEE 2 (0010)
: MT53E512M32D2NP-046 WT:E 8 (1000)
: K4U6E3S4AA-MGCR 9 (1001)
: H9HCNNNBKMMLXR-NEE 10 (1010)
Hi Furquan, there are 3 memory in the mem_list_variant. […]
No this is not correct. It looks like this and Makefile.inc were manually created?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46293
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I088517090da0565e55ffa978cb90cb879f3b6702
Gerrit-Change-Number: 46293
Gerrit-PatchSet: 1
Gerrit-Owner: Rasheed Hsueh
rasheed.hsueh@lcfc.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alec Wang
alec.wang@lcfc.corp-partner.google.com
Gerrit-CC: Jerry2 Huang
jerry2.huang@lcfc.corp-partner.google.com
Gerrit-CC: Leo3 Chen
leo3.chen@lcfc.corp-partner.google.com
Gerrit-CC: Sunshine Chao
sunshine.chao@lcfc.corp-partner.google.com
Gerrit-Comment-Date: Wed, 14 Oct 2020 00:37:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Zhuohao Lee
zhuohao@google.com
Gerrit-MessageType: comment