Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35214 )
Change subject: mb/google/kahlee/treeya: override sku_id() function
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35214/4/src/ec/google/chromeec/ec_b...
File src/ec/google/chromeec/ec_boardid.c:
https://review.coreboot.org/c/coreboot/+/35214/4/src/ec/google/chromeec/ec_b...
PS4, Line 31: sku_id
Mark __weak flag here and make sure this sku_id function is default.
https://review.coreboot.org/c/coreboot/+/35214/4/src/lib/coreboot_table.c
File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/35214/4/src/lib/coreboot_table.c@a2...
PS4, Line 227:
1. I thought that need remove sku_id here, make sure no other side effects.
2. default sku_id function move to ec_boardid.c
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35214
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I631f62021e8104a69a43667a811c9c23e3105596
Gerrit-Change-Number: 35214
Gerrit-PatchSet: 4
Gerrit-Owner: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Magf -
magf@bitland.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 03 Sep 2019 03:08:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment