Attention is currently required from: Patrick Rudolph.
Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40830 )
Change subject: [WIP]security/intel: Add option to eanble SMM flash access only
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Could `fast_spi_init()` in "soc/intel/common/block/smm/smihandler. […]
On the LPC (and therefore, is it perhaps not relevant?), the EISS bit is cleared by `lpc_soc_init` in "src/soc/intel/skylake/lpc.c"
BS_DEV_INIT is after BS_DEV_RESOURCES, where the lock would have been set (but it may not apply to LPC).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40830
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I157db885b5f1d0f74009ede6fb2342b20d9429fa
Gerrit-Change-Number: 40830
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Mon, 01 Feb 2021 00:56:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-MessageType: comment