Jett Rink has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32777 )
Change subject: ec/google/wilco: set diagnostic LEDs on boot failure
......................................................................
Patch Set 14: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/32777/14/src/ec/google/wilco/commands.c
File src/ec/google/wilco/commands.c:
https://review.coreboot.org/#/c/32777/14/src/ec/google/wilco/commands.c@208
PS14, Line 208: die_notify
makes sense. I thought die_notify needed to stay in mainboard for some reason. This is better.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32777
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If865ab8203f89e499130f4677fec166b40d80174
Gerrit-Change-Number: 32777
Gerrit-PatchSet: 14
Gerrit-Owner: Keith Short
keithshort@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Jett Rink
jettrink@chromium.org
Gerrit-Reviewer: Keith Short
keithshort@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 22 May 2019 19:36:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment