Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35496 )
Change subject: sc7180: Add clock driver
......................................................................
Patch Set 15:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35496/15/src/soc/qualcomm/sc7180/in...
File src/soc/qualcomm/sc7180/include/soc/clock.h:
https://review.coreboot.org/c/coreboot/+/35496/15/src/soc/qualcomm/sc7180/in...
PS15, Line 110: };
nit: it would be good to add some offset checks for this structure so we can be certain we don't mes […]
edit: Oh, I guess CB:35503 is already doing some of that
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35496
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f39252c887c36e8af43bc49289795000e4638d8
Gerrit-Change-Number: 35496
Gerrit-PatchSet: 15
Gerrit-Owner: mturney mturney
mturney@codeaurora.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Taniya Das
tdas@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 13 Nov 2019 23:56:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment