[coreboot-gerrit] [S] Change in coreboot[main]: soc/amd/stoneyridge: Use common block graphics driver

[CoolStar (Code Review)]

Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, Matt DeVillier, Paul Menzel.

CoolStar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78428?usp=email )

Change subject: soc/amd/stoneyridge: Use common block graphics driver
......................................................................

Patch Set 2:

(2 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/78428/comment/41d95038_78090e30 :
PS2, Line 11: don't write the
            : ACPI device for the GPU as stoney already defines it statically.
> wouldn't it be better to remove the statically defined version and just have commonality across the  […]

attempting to use the common version on Stoney causes an ACPI_BIOS_ERROR in windows on Stoney

File src/soc/amd/common/block/graphics/graphics.c:

https://review.coreboot.org/c/coreboot/+/78428/comment/14b146bb_656de48b :
PS2, Line 183: 	#if CONFIG(RUN_FSP_GOP)
> Why not keep the C version?

compilation fails if it’s not changed to the pre processor version as Stoney does not use FSP (and has no FSP headers)