build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39379 )
Change subject: libpayload/corebootfb: Replace obsolete macros FI and CHARS ......................................................................
Patch Set 1:
(17 comments)
https://review.coreboot.org/c/coreboot/+/39379/1/payloads/libpayload/drivers... File payloads/libpayload/drivers/video/corebootfb.c:
https://review.coreboot.org/c/coreboot/+/39379/1/payloads/libpayload/drivers... PS1, Line 99: chars[(coreboot_video_console.rows - 1) * coreboot_video_console.columns + column] = (VGA_COLOR_DEFAULT << 8); line over 96 characters
https://review.coreboot.org/c/coreboot/+/39379/1/payloads/libpayload/drivers... PS1, Line 118: chars[row * coreboot_video_console.columns + column] = (VGA_COLOR_DEFAULT << 8); line over 96 characters
https://review.coreboot.org/c/coreboot/+/39379/1/payloads/libpayload/drivers... PS1, Line 134: bgval = ((((vga_colors[bg] >> 0) & 0xff) >> (8 - fbinfo.blue_mask_size)) << fbinfo.blue_mask_pos) | line over 96 characters
https://review.coreboot.org/c/coreboot/+/39379/1/payloads/libpayload/drivers... PS1, Line 135: ((((vga_colors[bg] >> 8) & 0xff) >> (8 - fbinfo.green_mask_size)) << fbinfo.green_mask_pos) | line over 96 characters
https://review.coreboot.org/c/coreboot/+/39379/1/payloads/libpayload/drivers... PS1, Line 136: ((((vga_colors[bg] >> 16) & 0xff) >> (8 - fbinfo.red_mask_size)) << fbinfo.red_mask_pos); line over 96 characters
https://review.coreboot.org/c/coreboot/+/39379/1/payloads/libpayload/drivers... PS1, Line 137: fgval = ((((vga_colors[fg] >> 0) & 0xff) >> (8 - fbinfo.blue_mask_size)) << fbinfo.blue_mask_pos) | line over 96 characters
https://review.coreboot.org/c/coreboot/+/39379/1/payloads/libpayload/drivers... PS1, Line 138: ((((vga_colors[fg] >> 8) & 0xff) >> (8 - fbinfo.green_mask_size)) << fbinfo.green_mask_pos) | line over 96 characters
https://review.coreboot.org/c/coreboot/+/39379/1/payloads/libpayload/drivers... PS1, Line 139: ((((vga_colors[fg] >> 16) & 0xff) >> (8 - fbinfo.red_mask_size)) << fbinfo.red_mask_pos); line over 96 characters
https://review.coreboot.org/c/coreboot/+/39379/1/payloads/libpayload/drivers... PS1, Line 151: dst[(font_width - x) * (fbinfo.bits_per_pixel >> 3)] = font_glyph_filled(ch, x, y) ? fg : bg; line over 96 characters
https://review.coreboot.org/c/coreboot/+/39379/1/payloads/libpayload/drivers... PS1, Line 154: dst16 = (u16 *)(dst + (font_width - x) * (fbinfo.bits_per_pixel >> 3)); line over 96 characters
https://review.coreboot.org/c/coreboot/+/39379/1/payloads/libpayload/drivers... PS1, Line 159: dst[(font_width - x) * (fbinfo.bits_per_pixel >> 3) + 0] = fgval & 0xff; line over 96 characters
https://review.coreboot.org/c/coreboot/+/39379/1/payloads/libpayload/drivers... PS1, Line 160: dst[(font_width - x) * (fbinfo.bits_per_pixel >> 3) + 1] = (fgval >> 8) & 0xff; line over 96 characters
https://review.coreboot.org/c/coreboot/+/39379/1/payloads/libpayload/drivers... PS1, Line 161: dst[(font_width - x) * (fbinfo.bits_per_pixel >> 3) + 2] = (fgval >> 16) & 0xff; line over 96 characters
https://review.coreboot.org/c/coreboot/+/39379/1/payloads/libpayload/drivers... PS1, Line 163: dst[(font_width - x) * (fbinfo.bits_per_pixel >> 3) + 0] = bgval & 0xff; line over 96 characters
https://review.coreboot.org/c/coreboot/+/39379/1/payloads/libpayload/drivers... PS1, Line 164: dst[(font_width - x) * (fbinfo.bits_per_pixel >> 3) + 1] = (bgval >> 8) & 0xff; line over 96 characters
https://review.coreboot.org/c/coreboot/+/39379/1/payloads/libpayload/drivers... PS1, Line 165: dst[(font_width - x) * (fbinfo.bits_per_pixel >> 3) + 2] = (bgval >> 16) & 0xff; line over 96 characters
https://review.coreboot.org/c/coreboot/+/39379/1/payloads/libpayload/drivers... PS1, Line 169: dst32 = (u32 *)(dst + (font_width - x) * (fbinfo.bits_per_pixel >> 3)); line over 96 characters