29 Jul
2020
29 Jul
'20
12:34 p.m.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43977 )
Change subject: configs: Add a weird config for Asrock B85M Pro4 ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Maybe add one or several comment lines at the top of the file to describe the purpose of the config?
Something like
# Not meant for actual use. Exercises UBSAN, ...
https://review.coreboot.org/c/coreboot/+/43977/1/configs/config.asrock_b85m_... File configs/config.asrock_b85m_pro4.debug_smmstore_hotplug_gcov_ubsan_em100:
https://review.coreboot.org/c/coreboot/+/43977/1/configs/config.asrock_b85m_... PS1, Line 1: CONFIG_CCACHE=y not sure we should enforce this in here?
--
To view, visit https://review.coreboot.org/c/coreboot/+/43977
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8bc19a1987b405d5a654276050b00b956acbdf36
Gerrit-Change-Number: 43977
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 29 Jul 2020 09:34:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment