Pablo Stebler has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44750 )
Change subject: ec/hp/kbc1126: Wait a longer time after the first command
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44750/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44750/2//COMMIT_MSG@10
PS2, Line 10: EliteBook 8470p (because the fan control command was not sent).
How did you determine the timeout value? Trail and error?
I tried a few times and took twice the maximum time I got, rounded up to some power of two.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44750
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8623af75c062d6aa69d4412e0627d426c69019fb
Gerrit-Change-Number: 44750
Gerrit-PatchSet: 2
Gerrit-Owner: Pablo Stebler
pablo@stebler.xyz
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 12 Sep 2020 15:55:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment