EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37685 )
Change subject: soc/intel/cannonlake: Move GPIO PM configuration to soc level
......................................................................
Patch Set 17:
Patch Set 17:
Change Buffer to Package that can apply Integer. So we don't do any convert.
Sorry, I don't understand why Buffer was changed to Package?
Another interesting thing is we may consider the object. I can't printf %o GPMB[local] or DeRefOf(GPMB[local]). The log message of both will show [reference object] not value. If I used package GPMB[local] will show [reference object] and DeRefOf(GPMB[local]) will show the value :) You can play it if you have interesting as well.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37685
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I120f8369b8d3cf7ac821332bdfa124f6ed0570e9
Gerrit-Change-Number: 37685
Gerrit-PatchSet: 17
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aamir Bohra
aamir.bohra@intel.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 24 Dec 2019 18:51:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment