Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32252 )
Change subject: mb/intel/icelake_rvp: Add SMI handlers
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/32252/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32252/3//COMMIT_MSG@7
PS3, Line 7: mb/intel/icelake_rvp: Add SMI handlers
Is it Chrome EC specific? […]
Not really the, the CL adds strong functions for smm handlers defined under generic x86 smm handler module. However the calls inside those are chromeec specific, so until chrome ec configs are enabled, the APIs wouldn't be exposed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32252
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc0284b99bb2f4807ff2c0ec90b316730b251ddb
Gerrit-Change-Number: 32252
Gerrit-PatchSet: 4
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 11 Apr 2019 12:15:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment