Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30762 )
Change subject: arch/x86: Remove weak tsc_freq_mhz() implementation
......................................................................
Patch Set 6:
Patch Set 6:
This seems to remove the possibility for a platforms not using UDELAY_TSC to have a working implementation of this function using a tsc_freq_mhz() implementation. Is that intended?
I guess no. I don't see why TSC_CONSTANT_RATE should depend on UDELAY_TSC.
cpu/x86/tsc/Makefilei.inc is ... interesting
I welcome the change to cleanup the Kconfig dependency.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30762
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id3b105ea3aac37cd0cba18ce2fb06d87a055486f
Gerrit-Change-Number: 30762
Gerrit-PatchSet: 6
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 01 Feb 2019 20:02:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment