Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44261 )
Change subject: mb/google/volteer: Implement variant_devtree_update for volteer sku's
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44261/7/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/volteer/variant.c:
https://review.coreboot.org/c/coreboot/+/44261/7/src/mainboard/google/voltee...
PS7, Line 15: (sku_id == 3) || (sku_id == 5)
I think we could add a 1-bit FW_CONFIG field for Hybrid Storage.
Actually, can't we runtime probe for hybrid storage? I thought FSP already did that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44261
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5c3bcfafe1710155bb47f706c3568dd9500c1975
Gerrit-Change-Number: 44261
Gerrit-PatchSet: 7
Gerrit-Owner: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Thu, 06 Aug 2020 17:14:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shaunak Saha
shaunak.saha@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment