Attention is currently required from: Tarun Tuli, Dinesh Gehlot, Kapil Porwal.
Hello Tarun Tuli, Subrata Banik, Kapil Porwal,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/70272
to look at the new patch set (#4).
Change subject: soc/intel/meteorlake: Drop casts around `soc_read_pmc_base()` ......................................................................
soc/intel/meteorlake: Drop casts around `soc_read_pmc_base()`
The `soc_read_pmc_base()` function returns an `uintptr_t`, which is then casted to a pointer type for use with `read32()` and/or `write32()`. But since commit b324df6a540d154cc9267c0398654f9142aae052 (arch/x86: Provide readXp/writeXp helpers in arch/mmio.h), the `read32p()` and `write32p()` functions live in `arch/mmio.h`. These functions use the `uintptr_t type for the address parameter instead of a pointer type, and using them with the `soc_read_pmc_base()` function allows dropping the casts to pointer.
BUG=none TEST=Build and Boot verified on google/rex
Port of commit f585c6eeeafb ("soc/intel: Drop casts around `soc_read_pmc_base()`")
Signed-off-by: Dinesh Gehlot digehlot@google.com Change-Id: I914190f2d2d0507c84b19340159990f9b62ce101 --- M src/soc/intel/meteorlake/acpi.c 1 file changed, 25 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/70272/4