Attention is currently required from: Fred Reitberger, Jason Glenesk, Matt DeVillier, Nico Huber, Raul Rangel.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74993?usp=email )
Change subject: soc/amd/common/data_fabric/domain: write _STA method in SSDT
......................................................................
Patch Set 8:
(1 comment)
Patchset:
PS8:
This seems odd, I wonder why it should have an _STA object at all? […]
the domain could be set to off in the devicetree. not that that case would make much sense to me, but that would cover that case.
the newer socs from cezanne on had an _sta method that always returned 0xf which is why i implemented this
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74993?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ied48b48113f6e871e90d17cbd216be003f05b5ef
Gerrit-Change-Number: 74993
Gerrit-PatchSet: 8
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Fri, 02 Jun 2023 16:12:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment