Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40762 )
Change subject: cpu/x86/mtrr/earlymtrr: Validate MTRR arguments ......................................................................
Patch Set 4:
(5 comments)
https://review.coreboot.org/c/coreboot/+/40762/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40762/3//COMMIT_MSG@7 PS3, Line 7: src/cpu/x86/mtrr/earlymtrr: Validate MTRR arguments
Please remove `src/` from the beginning.
Done
https://review.coreboot.org/c/coreboot/+/40762/3//COMMIT_MSG@10 PS3, Line 10: Programming says the following about variable MTRRs:
FWIW, these constraints are x86 architectural.
Right, I was just stating my source.
https://review.coreboot.org/c/coreboot/+/40762/3//COMMIT_MSG@17 PS3, Line 17: 16-Mbyte boundary.
aka naturally aligned
Done
https://review.coreboot.org/c/coreboot/+/40762/3//COMMIT_MSG@18 PS3, Line 18: 2 n
2^n
Done
https://review.coreboot.org/c/coreboot/+/40762/3//COMMIT_MSG@24 PS3, Line 24: enabled.
fyi, src/arch/x86/postcar_loader.c has code for setting up MTRRs based on regions passed in.
Ack