Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35799 )
Change subject: soc/intel/sgx: convert SGX and PRMRR devicetree options to Kconfig ......................................................................
Patch Set 12:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35799/12/src/soc/intel/icelake/chip... File src/soc/intel/icelake/chip.h:
https://review.coreboot.org/c/coreboot/+/35799/12/src/soc/intel/icelake/chip... PS12, Line 278: get_prmrr_size This is not a good place for function declaration
https://review.coreboot.org/c/coreboot/+/35799/12/src/soc/intel/icelake/memm... File src/soc/intel/icelake/memmap.c:
https://review.coreboot.org/c/coreboot/+/35799/12/src/soc/intel/icelake/memm... PS12, Line 51: get_prmrr_size I'd use a common definition. You can get the chip config in the implementation instead of via the argument.