Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45134 )
Change subject: console: Unify overriding console log level with get_option()
......................................................................
Patch Set 11:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45134/10/src/include/option.h
File src/include/option.h:
https://review.coreboot.org/c/coreboot/+/45134/10/src/include/option.h@26
PS10, Line 26: return cmos_get_option(dest, name);
Similarly, we could have here: […]
I added a generic mainboard_get_option() because mainboard may not choose to use VPD.
https://review.coreboot.org/c/coreboot/+/45134/10/src/include/option.h@30
PS10, Line 30: return get_console_override_option(dest, name);
I don't understand why this needs another function. We could also have the […]
Done
https://review.coreboot.org/c/coreboot/+/45134/10/src/include/option.h@32
PS10, Line 32: }
If we decide for a normalized […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45134
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I278e392bed178df7a8cdb90685963c1fedf0bcc4
Gerrit-Change-Number: 45134
Gerrit-PatchSet: 11
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Julien Viard de Galbert
coreboot-review-ju@vdg.name
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Rocky Phagura
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: insomniac
insomniac@slackware.it
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 21 Sep 2020 07:31:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment