[coreboot-gerrit] Change in coreboot[master]: sc7180: Add clock driver

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35496 )

Change subject: sc7180: Add clock driver
......................................................................

Patch Set 13:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35496/9/src/soc/qualcomm/sc7180/clo... 
File src/soc/qualcomm/sc7180/clock.c:

https://review.coreboot.org/c/coreboot/+/35496/9/src/soc/qualcomm/sc7180/clo... 
PS9, Line 65: 0x00004805
> Thanks Julius. I understand that we should use the individual bits. […]

You're welcome to use either the new (SET32_BITFIELDS) or the old way (just shifting and ORing the bits directly like for user_ctl below), but you need to use either one of those with the individual bits named and separated out. We can't submit code with magic numbers.