build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48479 )
Change subject: mb/google/guybrush: Add new mainboard ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/48479/3/src/mainboard/google/guybru... File src/mainboard/google/guybrush/variants/baseboard/fsps_baseboard.c:
https://review.coreboot.org/c/coreboot/+/48479/3/src/mainboard/google/guybru... PS3, Line 117: } else { else is not generally useful after a break or return
https://review.coreboot.org/c/coreboot/+/48479/3/src/mainboard/google/guybru... PS3, Line 179: } else { else is not generally useful after a break or return
https://review.coreboot.org/c/coreboot/+/48479/3/src/mainboard/google/guybru... File src/mainboard/google/guybrush/variants/baseboard/gpio_baseboard.c:
https://review.coreboot.org/c/coreboot/+/48479/3/src/mainboard/google/guybru... PS3, Line 58: /* AC_PRES */ 'PRES' may be misspelled - perhaps 'PRESS'?
https://review.coreboot.org/c/coreboot/+/48479/3/src/mainboard/google/guybru... PS3, Line 59: PAD_NF(GPIO_23, AC_PRES, PULL_UP), 'PRES' may be misspelled - perhaps 'PRESS'?