Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45565 )
Change subject: mb/google/zork/vilboz: Enable SAR proximity sensor STH9324 ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45565/2/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/gpio.c:
https://review.coreboot.org/c/coreboot/+/45565/2/src/mainboard/google/zork/v... PS2, Line 10: bid_1_gpio_set_stage_ram Is P-sensor interrupt used only on board with version 1 or all future board versions as well? If it is used on all future board versions too, then you will have to add another table that will configure this interrupt line for future board versions and will be returned on line 39.
https://review.coreboot.org/c/coreboot/+/45565/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45565/1/src/mainboard/google/zork/v... PS1, Line 140: STH9324
According to https://partnerissuetracker.corp.google.com/issues/161759253#comment8 , […]
I think it would be good to get the driver in before landing this change. So that the ACPI information is correctly supplied here as per the driver expectations.