Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Angel Pons. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55205 )
Change subject: mb/intel/adlrvp: Use device aliases ......................................................................
Patch Set 3:
(8 comments)
File src/mainboard/intel/adlrvp/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/55205/comment/357962ea_44d3c4d2 PS2, Line 320: device pci 10.0 off end : device pci 10.1 off end : device pci 10.6 off end # THC0 : device pci 10.7 off end # THC1
chipset.cb only has the first two: […]
Below devices are THC0 and 1 for ADL-P device pci 10.0 off end device pci 10.1 off end
And below devices are THC0 and 1 for ADL-S. device pci 10.6 off end # THC0 device pci 10.7 off end # THC1
I'm planning to add ADL-S code sooner, will add those devices in chipset.cb.
Hope we are good till then?
https://review.coreboot.org/c/coreboot/+/55205/comment/c036660f_75727eb3 PS2, Line 324: device pci 11.0 off end : device pci 11.1 off end : device pci 11.2 off end : device pci 11.3 off end : device pci 11.4 off end : device pci 11.5 off end
chipset.cb doesn't have any of these. […]
same these devices belongs to ADL-S
https://review.coreboot.org/c/coreboot/+/55205/comment/1a7e4276_edb0298e PS2, Line 331: device pci 12.5 off end
chipset. […]
I don't see this device, mostly some mistake, better to remove this device from list
https://review.coreboot.org/c/coreboot/+/55205/comment/cb3c65a0_47f09a94 PS2, Line 334: device pci 13.1 off end
chipset. […]
Its for ADL-S
https://review.coreboot.org/c/coreboot/+/55205/comment/578fa04d_661d163e PS2, Line 362: device pci 16.2 off end # CSME : device pci 16.3 off end # CSME
These two devices don't appear in chipset.cb for some reason. […]
I will add those in chipset.cb now.
CB:55209
https://review.coreboot.org/c/coreboot/+/55205/comment/8ac42d76_8ef9374e PS2, Line 317: chip drivers/usb/acpi : register "desc" = ""Root Hub"" : register "type" = "UPC_TYPE_HUB" : device usb 0.0 on : chip drivers/usb/acpi : register "desc" = ""Bluetooth"" : register "type" = "UPC_TYPE_INTERNAL" : device usb 2.9 on end : end : end : end
chipset.cb also has a `chip drivers/usb/acpi` with stuff inside. […]
Ack
https://review.coreboot.org/c/coreboot/+/55205/comment/afb7762b_875337d8 PS2, Line 352: device ref pch_espi on end
alderlake chipset.cb already enables this: […]
Ack
https://review.coreboot.org/c/coreboot/+/55205/comment/be2547c4_a7ef9e76 PS2, Line 366: device ref fast_spi on end
alderlake chipset.cb already enables this: […]
Ack