Jes Klinke has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39359 )
Change subject: soc/intel/tigerlake: Save DIMM info by available nodes
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39359/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39359/1//COMMIT_MSG@9
PS1, Line 9: TEST= make build image returns correct dimm info by mosys and dmidecode
: with TGL-U and TGL-Y + MICA + LPDDR4
Based on MAX_NODE, MAX_CH and ARRAY_SIZE(mem_info->dimm), 8 entries seem correct. […]
I have used dmidecode to verify that public coreboot with this patch displays the same information in the Memory Device section, as do the private intel repo.
Assuming we want the public coreboot to be "on par" with Intels private repo, in order to stop using the latter, I guess that is sufficient.
I cannot speak to whether the displayed information is correct, nor whether array sizes should be adjusted. Perhaps we can have a followup CL.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39359
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I951ea94c280b7dd5b67f320a264d13fca82a4596
Gerrit-Change-Number: 39359
Gerrit-PatchSet: 3
Gerrit-Owner: Jes Klinke
jbk@chromium.org
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Jes Klinke
jbk@google.com
Gerrit-CC: Raj Astekar
raj.astekar@intel.corp-partner.google.com
Gerrit-Comment-Date: Tue, 10 Mar 2020 21:06:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jes Klinke
jbk@chromium.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment